Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebeat/module/{iis,o365}: Fix uri_parts ingest pipeline processor output wrong extension #38216

Merged
merged 8 commits into from
Mar 13, 2024
Merged

filebeat/module/{iis,o365}: Fix uri_parts ingest pipeline processor output wrong extension #38216

merged 8 commits into from
Mar 13, 2024

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Mar 7, 2024 •
edited
Loading

Proposed commit message

This PR fixes the errors in the pipeline tests which generates incorrect values for the extension field of uri_parts processor. Bug fix done in Elasticsearch to remove the incorrect url.extension values from the uri_parts ingest pipeline processor. The affected beats module should remove this field from the generated sample documents. IIS error module and the o365 audit log modules are effected by this change.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd beats/filebeat
GENERATE=true TESTING_FILEBEAT_MODULES=iis,o365 mage -v pythonIntegTest

Related issues

This fixes the python integration tests failure reported in the below PR

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @muthu-mps? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b url-extension-value-fix upstream/url-extension-value-fix
git merge upstream/main
git push upstream url-extension-value-fix

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 7, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-03-13T04:41:12.108+0000

  • Duration: 150 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 29167
Skipped 2046
Total 31213

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@muthu-mps muthu-mps added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Mar 7, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2024
@muthu-mps muthu-mps marked this pull request as ready for review March 12, 2024 03:20
@muthu-mps muthu-mps requested review from a team as code owners March 12, 2024 03:20
leehinman
leehinman approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ShourieG
ShourieG approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

shmsr
shmsr reviewed Mar 13, 2024
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
shmsr
shmsr requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment.

@shmsr shmsr changed the title [Filebeat] Fix uri_parts ingest pipeline processor output wrong extension filebeat/module/{iis,o365}: Fix uri_parts ingest pipeline processor output wrong extension Mar 13, 2024
@muthu-mps @shmsr
Update CHANGELOG.next.asciidoc
8c88e40 
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 13, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @muthu-mps

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 13, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @muthu-mps

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @muthu-mps

@muthu-mps muthu-mps requested a review from shmsr March 13, 2024 04:58
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @muthu-mps

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @muthu-mps

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @muthu-mps

@muthu-mps muthu-mps merged commit 8af7d19 into elastic:main Mar 13, 2024
108 of 112 checks passed
@cmacknz cmacknz mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

@leehinman leehinman leehinman approved these changes

@shmsr shmsr shmsr approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@muthu-mps muthu-mps

Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@muthu-mps @elasticmachine @shmsr @leehinman @ShourieG @apmmachine